Merged
Conversation
dschmidt
force-pushed
the
chore/replace-custom-nginx-with-upstream
branch
from
898ff01 to
eefb227
Compare
dschmidt
force-pushed
the
chore/replace-custom-nginx-with-upstream
branch
2 times, most recently
from
870fb34 to
5ac80e1
Compare
Member
|
Thank you for the PR, but I think we can just get rid of the docker image entirely. The benefits of it are kind of only theoretical by now. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dschmidt
force-pushed
the
chore/replace-custom-nginx-with-upstream
branch
from
5ac80e1 to
28f7bbb
Compare
dschmidt
changed the title
kulmann
reviewed
Feb 26, 2026
Member
kulmann
left a comment
kulmann
left a comment
There was a problem hiding this comment.
I addition to the files you deleted, can you spot a place where it was actually built? I can't find anything in the Makefile or in .woodpecker.star - do you?
Contributor
Author
|
Nope, I guess it was never ported to woodpecker |
kulmann
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
docker-compose.ymlis unaffected (uses pre-built OpenCloud images withdist/mounted as a volume)🤖 Generated with Claude Code